Add Harmonic 🎵 #324
Merged
Add Harmonic 🎵 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
ahcorde
requested changes
Dec 1, 2022
Signed-off-by: Ian Chen <[email protected]>
ahcorde
previously requested changes
Dec 2, 2022
Signed-off-by: Ian Chen <[email protected]>
azeey
reviewed
Dec 5, 2022
|
|
||
| ``` | ||
| # replace <path_to_install_dir> to your Gazebo installation directory | ||
| GZ_CONFIG_PATH=<path_to_install_dir>/share/gz/ |
There was a problem hiding this comment.
The garden version has GZ_CONFIG_PATH=/usr/local/share/gazebo/. Should that be updated as well?
There was a problem hiding this comment.
yep updated and ported more fixes to Garden in 937916a
| drivers. | ||
|
|
||
| The Ogre 2 debs from the osrfoundation repository are built from a fork of | ||
| Ogre's `v2-3` branch with changes needed for deb packaging and allowing it to |
There was a problem hiding this comment.
The garden version has v2-1. I think we need to update that as well.
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
azeey
approved these changes
Dec 5, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
Add basic information about Gazebo Harmonic.
I did similar changes as the ones in #211 for Garden. The installation instructions were copied from Garden.
Feel free to pick a different emoji if that fits the Harmonic name better :)
Part of gazebo-tooling/release-tools#856 and gazebo-tooling/release-tools#853